Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push docker images to GHCR instead of dockerhub #376

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Push docker images to GHCR instead of dockerhub #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab41b23
Fix hack/release_check.py
soharab-ic Aug 22, 2024
752bfef
Updated nodejs environment version
soharab-ic Aug 22, 2024
86f60d6
Replace dockerhub login to ghcr login in release workflow
soharab-ic Aug 22, 2024
3d8b041
Change repo prefix to ghcr.io/fission
soharab-ic Aug 22, 2024
46113c0
Remove armv7 support
soharab-ic Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,12 @@ jobs:
version: latest
use: 'true'
buildkitd-flags: --debug
- name: Login to DockerHub
uses: docker/login-action@v1
- name: Login to ghcr.io
uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Trigger Release
run: |
make verify-builder
Expand Down
7 changes: 3 additions & 4 deletions hack/release_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,17 @@

FISSION_REPO = "ghcr.io/fission"

GHCR_URL = "https://ghcr.io/v2/{repo}/{env}/tags/{tag}"
GHCR_URL = "https://ghcr.io/v2/{repo}/{env}/tags/list"
def check_if_image_exists(image,tag):
docker_uri = GHCR_URL.format(
repo=FISSION_REPO,
env=image,
tag=tag,
env=image
)
resp = requests.get(docker_uri)
json_resp = resp.json()
if "message" in json_resp and "not found" in json_resp['message']:
return False
elif "images" in json_resp and len(json_resp["images"]) > 0:
elif "tags" in json_resp and tag in json_resp["images"]:
return True
else:
return False
Expand Down
6 changes: 3 additions & 3 deletions nodejs/envconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"runtimeVersion": "20.16.0-debian",
"shortDescription": "Fission NodeJS environment based on Express with some basic dependencies added",
"status": "Stable",
"version": "1.32.3"
"version": "1.32.4"
},
{
"builder": "node-builder-22",
Expand All @@ -44,7 +44,7 @@
"runtimeVersion": "22.6.0",
"shortDescription": "Fission NodeJS environment based on Express with some basic dependencies added",
"status": "Stable",
"version": "1.32.3"
"version": "1.32.4"
},
{
"builder": "node-builder",
Expand All @@ -68,6 +68,6 @@
"runtimeVersion": "20.16.0",
"shortDescription": "Fission NodeJS environment based on Express with some basic dependencies added",
"status": "Stable",
"version": "1.32.3"
"version": "1.32.4"
}
]
4 changes: 2 additions & 2 deletions rules.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Platforms to build in multi-architecture images.
PLATFORMS ?= linux/amd64,linux/arm64,linux/arm
PLATFORMS ?= linux/amd64,linux/arm64

# Repository prefix and tag to push multi-architecture images to.
REPO ?= fission
REPO ?= ghcr.io/fission
TAG ?= dev
DOCKER_FLAGS ?= --push --progress plain
FISSION_VERSION ?= v1.20.3
Expand Down
Loading