Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable typescript strictNullChecks #468

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Nov 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: #465

What is the new behavior?

This pull request includes changes to improve error handling, type safety, and code readability across several files in the project. The most important changes include adding error handling for missing package versions, improving type assertions, and enhancing null safety in various functions.

Error Handling Improvements:

  • prisma/seeder.ts: Added error handling to check if the idn-area-data package is installed before proceeding with log generation.

Type Safety Enhancements:

  • src/app.module.ts: Added type assertions to ensure the correct types are used for throttle configuration values.
  • src/main.ts: Added type assertion to ensure the version is a string when setting up the API documentation with Swagger.

Null Safety Enhancements:

Code Readability Improvements:

Other information

None

@fityannugroho fityannugroho added the refactor Change code without add, update, or delete any features label Nov 23, 2024
@fityannugroho fityannugroho linked an issue Nov 23, 2024 that may be closed by this pull request
@fityannugroho fityannugroho merged commit 3e8ee52 into main Nov 23, 2024
11 checks passed
@fityannugroho fityannugroho deleted the 465-enable-typescript-strictnullchecks branch November 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change code without add, update, or delete any features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable TypeScript strictNullChecks
1 participant