Enable typescript strictNullChecks
#468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #465
What is the new behavior?
This pull request includes changes to improve error handling, type safety, and code readability across several files in the project. The most important changes include adding error handling for missing package versions, improving type assertions, and enhancing null safety in various functions.
Error Handling Improvements:
prisma/seeder.ts
: Added error handling to check if theidn-area-data
package is installed before proceeding with log generation.Type Safety Enhancements:
src/app.module.ts
: Added type assertions to ensure the correct types are used for throttle configuration values.src/main.ts
: Added type assertion to ensure the version is a string when setting up the API documentation with Swagger.Null Safety Enhancements:
src/common/decorator/EqualsAny.ts
: Improved null safety by using optional chaining and nullish coalescing operators in theEqualsAnyConstraint
class.src/common/decorator/IsNotSymbol.ts
: Enhanced null safety in theIsNotSymbolConstraint
class by using optional chaining and nullish coalescing operators. [1] [2]Code Readability Improvements:
src/common/utils/coordinate.ts
: Refactored theconvertCoordinate
function to improve readability and added error handling for invalid coordinate formats.src/island/island.service.ts
: Added type assertion to ensure the province is not null when finding a unique province.Other information
None