just some corrections #147
Conversation
GPIO Pin number does not match the given wiring
Node.js version 18 seems to work as well
| @@ -149,7 +149,7 @@ Continuously move a servo connected to GPIO10 clockwise and anti-clockwise. | |||
| ```js | |||
| const Gpio = require('pigpio').Gpio; | |||
|
|
|||
| const motor = new Gpio(10, {mode: Gpio.OUTPUT}); | |||
| const motor = new Gpio(13, {mode: Gpio.OUTPUT}); | |||
There was a problem hiding this comment.
Why should the GPIO number specified here be changed from 10 to 13? In my opinion 10 is the correct GPIO number as it corresponds to the fritzing circuit diagram shown directly above the code here. Please not that the fritzing is for an older Pi 1 which has a 24 pin GPIO header, not a newer Pi with a 40 pin GPIO header.
There was a problem hiding this comment.
well, doesn't a Pi 1 seem a bit old and no longer too common - most users would no longer benefit from the sown circuit diagrams? I counted 4 Fritzing diagrams which I would volunteer to recreate for, e.g., a RasPi Zero. I should even have any required hardware at hand to actually test the examples in reality (incl. waveform generation which I could check with a pocket oscilloscope)
| @@ -9,7 +9,7 @@ A wrapper for the [pigpio C library](https://github.com/joan2937/pigpio) to | |||
| enable fast GPIO, PWM, servo control, state change notification and interrupt | |||
| handling with **Node.js** on the Raspberry Pi Zero, 1, 2, 3 or 4. | |||
|
|
|||
| pigpio supports Node.js versions 10, 12, 14, 15 and 16. | |||
| pigpio supports Node.js versions 10, 12, 14, 15 and 16 (but version 18 seems to work as well). | |||
There was a problem hiding this comment.
I don't like the idea of adding text that says that something might work. In reality, I would also expect pigpio to function with Node.js v18, but I haven't tested it extensively yet.
There was a problem hiding this comment.
agreed. Do you have a recommendation, which tests I should run (without requiring too much external hardware) in order to verify my assumption?
Thank you very much for this wonderful library!
I've just started experimenting with it, but already ran across some minor errors which I would like to see corrected.
With greetings from Germany,
Andreas Rozek