Persist deleted entities who still have _report records to end models #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
No github issue, but will include Ads and other entities that can be hard-deleted from the source _history tables. They still have records in the _report tables, though their IDs get updated to
-1
.This PR will result in the following new package version:
v0.4.1
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
inner joins
in each end model to beleft joins
.<entity>_history
source tables, though any associated<entity>_report
records persist with new<entity>_id
values of-1
. This update ensures that the report records persist into the package's end models in these cases.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Validation tests updated and passing
If you had to summarize this PR in an emoji, which would it be?
🍏