Merge pull request #31 from jackiexsun/patch-1

Update int_github__issue_joined.sql
fivetran · Mar 10, 2022 · 073c44e · 073c44e
2 parents 842f4d0 + 30ac783
commit 073c44e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
-# dbt_github v0.5.0
+# dbt_github v0.5.1
+## Fixes
+- The `url_link` logic within `int_github__issue_joined` was focused on only providing the correct url for pull requests. This update includes a `case when` statement to provide the accurate url logic for both Issues and Pull Requests. ([#31](https://github.com/fivetran/dbt_github/pull/31))
 
+## Contributors
+- [@jackiexsun](https://github.com/jackiexsun) ([#31](https://github.com/fivetran/dbt_github/pull/31))
+# dbt_github v0.5.0
 ## 🚨 Breaking Changes 🚨
 - The addition of the `label` source model results in the reference within `int_github__issue_label` to break. As a result, with the addition of upstream changes within `dbt_github_source` and the new `int_github__issue_label_join` model this issue has been resolved. ([#26](https://github.com/fivetran/dbt_github/pull/26))
   - Please note: It is important you kick off a historical resync of your connector to account for the [connector changes](https://fivetran.com/docs/applications/github/changelog#april2021) from April 2021.

diff --git a/dbt_project.yml b/dbt_project.yml
@@ -1,6 +1,6 @@
 config-version: 2
 name: 'github'
-version: '0.5.0'
+version: '0.5.1'
 require-dbt-version: [">=1.0.0", "<2.0.0"]
 models:
   github:

diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'github_integration_tests'
-version: '0.5.0'
+version: '0.5.1'
 config-version: 2
 
 profile: 'integration_tests'

diff --git a/models/intermediate/int_github__issue_joined.sql b/models/intermediate/int_github__issue_joined.sql
@@ -59,7 +59,10 @@ pull_request as (
 
 select
   issue.*,
-  {{ dbt_utils.concat(["'https://github.com/'",'repository_teams.repository',"'/pull/'", 'issue.issue_number']) }} as url_link,
+  case 
+    when issue.is_pull_request then {{ dbt_utils.concat(["'https://github.com/'",'repository_teams.repository',"'/pull/'", 'issue.issue_number']) }}
+    else {{ dbt_utils.concat(["'https://github.com/'",'repository_teams.repository',"'/issues/'", 'issue.issue_number']) }}
+  end as url_link,
   issue_open_length.days_issue_open,
   issue_open_length.number_of_times_reopened,
   labels.labels,
@@ -96,4 +99,4 @@ left join pull_request
 left join pull_request_times
   on issue.issue_id = pull_request_times.issue_id
 left join pull_request_reviewers
-  on pull_request.pull_request_id = pull_request_reviewers.pull_request_id
+  on pull_request.pull_request_id = pull_request_reviewers.pull_request_id