Skip to content

Commit

Permalink
Merge pull request #32 from fivetran/feature/google-ads-api-default
Browse files Browse the repository at this point in the history
feature/google-ads-api-default
  • Loading branch information
fivetran-joemarkiewicz authored Jun 28, 2022
2 parents 9f3edbc + dd3b73a commit e261f7f
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 13 deletions.
10 changes: 5 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
dbt deps
dbt seed --target postgres --full-refresh
dbt run --target postgres --full-refresh
dbt run --target postgres --full-refresh --vars '{api_source: google_ads}'
dbt run --target postgres --full-refresh --vars '{api_source: adwords}'
dbt test --target postgres
- run:
name: "Run Tests - Spark"
Expand All @@ -42,7 +42,7 @@ jobs:
dbt deps
dbt seed --target spark --full-refresh
dbt run --target spark --full-refresh
dbt run --target spark --full-refresh --vars '{api_source: google_ads}'
dbt run --target spark --full-refresh --vars '{api_source: adwords}'
dbt test --target spark
- run:
name: "Run Tests - Redshift"
Expand All @@ -53,7 +53,7 @@ jobs:
dbt deps
dbt seed --target redshift --full-refresh
dbt run --target redshift --full-refresh
dbt run --target redshift --full-refresh --vars '{api_source: google_ads}'
dbt run --target redshift --full-refresh --vars '{api_source: adwords}'
dbt test --target redshift
- run:
name: "Run Tests - Snowflake"
Expand All @@ -64,7 +64,7 @@ jobs:
dbt deps
dbt seed --target snowflake --full-refresh
dbt run --target snowflake --full-refresh
dbt run --target snowflake --full-refresh --vars '{api_source: google_ads}'
dbt run --target snowflake --full-refresh --vars '{api_source: adwords}'
dbt test --target snowflake
- run:
name: "Run Tests - BigQuery"
Expand All @@ -78,5 +78,5 @@ jobs:
dbt deps
dbt seed --target bigquery --full-refresh
dbt run --target bigquery --full-refresh
dbt run --target bigquery --full-refresh --vars '{api_source: google_ads}'
dbt run --target bigquery --full-refresh --vars '{api_source: adwords}'
dbt test --target bigquery
1 change: 0 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
Pull Request
**Are you a current Fivetran customer?**
<!--- Please tell us your name, title and company -->

Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# dbt_google_ads v0.7.0
## 🚨 Breaking Changes 🚨
- The `api_source` variable is now defaulted to `google_ads` as opposed to `adwords`. The Adwords API has since been deprecated by Google and is now no longer the standard API for the Google Ads connector. Please ensure you are using a Google Ads API version of the Fivetran connector before upgrading this package. ([#32](https://github.com/fivetran/dbt_google_ads/pull/32))
- Please note, the `adwords` version of this package will be fully removed from the package in August of 2022. This means, models under `models/adwords_connector` will be removed in favor of `models/google_ads_connector` models.
# dbt_google_ads v0.6.1
- Updated google_ads__url_ad_adapter link in README (Thank you to @bkimjin! ([#26](https://github.com/fivetran/dbt_google_ads/issues/26)))
# dbt_google_ads v0.6.0
Expand Down
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,14 @@ Include in your `packages.yml`
```yaml
packages:
- package: fivetran/google_ads
version: [">=0.6.0", "<0.7.0"]
version: [">=0.7.0", "<0.8.0"]
```
## Configuration
As previously mentioned, package allows users to leverage either the Adwords API or the Google Ads API. You will be able to determine which API your connector is using by navigating within your Fivetran UI to the `setup` tab -> `edit connection details` link -> and reference the `API configuration` used.
This package allows users to leverage either the Adwords API or the Google Ads API. You will be able to determine which API your connector is using by navigating within your Fivetran UI to the `setup` tab -> `edit connection details` link -> and reference the `API configuration` used. You will want to refer to the respective configuration steps below based off the API used by your connector.

> **Note**: As of April, 2022 all Fivetran Google Ads connectors leverage the Google Ads API rather than Adwords. Additionally, please be aware that the Adwords API version of the package will be sunset in August of 2022.
### Google Ads API Configuration
If your connector is setup using the Google Ads API then you will need to configure your `dbt_project.yml` with the below variable:

Expand All @@ -42,7 +43,7 @@ If your connector is setup using the Google Ads API then you will need to config
config-version: 2
vars:
api_source: google_ads ## adwords by default
api_source: google_ads ## google_ads by default, but may be changed to 'adwords' if using a previous version of the connector.
```

### Adwords API Configuration
Expand Down
4 changes: 2 additions & 2 deletions dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'google_ads'
version: '0.6.1'
version: '0.7.0'
config-version: 2
require-dbt-version: [">=1.0.0", "<2.0.0"]
models:
Expand All @@ -17,7 +17,7 @@ vars:
ad_group_history: "{{ ref('stg_google_ads__ad_group_history') }}"
ad_history: "{{ ref('stg_google_ads__ad_history') }}"
ad_final_url_history: "{{ ref('stg_google_ads__ad_final_url_history') }}"
api_source: adwords
api_source: google_ads
google_ads__url_passthrough_metrics: []
google_ads__criteria_passthrough_metrics: []
google_ads__ad_stats_passthrough_metrics: []
2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'google_ads_integration_tests'
version: '0.6.1'
version: '0.7.0'
profile: 'integration_tests'
config-version: 2

Expand Down
2 changes: 1 addition & 1 deletion packages.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
packages:
- package: fivetran/google_ads_source
version: [">=0.6.0", "<0.7.0"]
version: [">=0.7.0", "<0.8.0"]

0 comments on commit e261f7f

Please sign in to comment.