Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add line item standardized model #83

Merged
merged 24 commits into from
Aug 14, 2024

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Jul 3, 2024

PR Overview

This PR will address the following Issue/Feature:

  • Quarterly project

This PR will result in the following new package version:

  • v0.13.0 for new model

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Features

  • Addition of the shopify__line_item_enhanced model. This model constructs a comprehensive, denormalized analytical table that enables reporting on key revenue, subscription, customer, and product metrics from your billing platform. It’s designed to align with the schema of the *__line_item_enhanced model found in Shopify, Recharge, Stripe, Zuora, and Recurly, offering standardized reporting across various billing platforms. To see the kinds of insights this model can generate, explore example visualizations in the Fivetran Billing Model Streamlit App. Visit the app for more details.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • See internal ticket for schema sample.

If you had to summarize this PR in an emoji, which would it be?

🧥

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli thanks for working through this update! I have a few comments, questions, and suggestions below. Let me know if you would like to sync in more detail regarding any of my comments.

Thanks!

models/common_data_models/shopify__common_data_models.yml Outdated Show resolved Hide resolved
models/common_data_models/shopify__line_item_enhanced.sql Outdated Show resolved Hide resolved
models/common_data_models/shopify__line_item_enhanced.sql Outdated Show resolved Hide resolved
models/common_data_models/shopify__line_item_enhanced.sql Outdated Show resolved Hide resolved
models/common_data_models/shopify__common_data_models.yml Outdated Show resolved Hide resolved
integration_tests/dbt_project.yml Outdated Show resolved Hide resolved
@fivetran-reneeli fivetran-reneeli marked this pull request as draft July 16, 2024 19:22
@fivetran-reneeli fivetran-reneeli marked this pull request as ready for review July 17, 2024 17:11
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli thanks for addressing my comments! I have a few additional notes I would like you to address below. Additionally, please add a CHANGELOG entry for this update. Once those are addressed this should be good to go!

dbt_project.yml Outdated Show resolved Hide resolved
models/common_data_models/shopify__common_data_models.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @fivetran-reneeli thanks for working through all my review notes. Please regen the docs and then this will be good!

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the title add line item normalized model add line item standardized model Aug 6, 2024
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-reneeli fivetran-reneeli merged commit 3888e08 into main Aug 14, 2024
9 checks passed
@fivetran-reneeli fivetran-reneeli deleted the feature/standardized-line-item-model branch August 14, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants