-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Brand and organization variable configs #181
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,3 +1,24 @@ | ||||||
# dbt_zendesk v0.19.2 | ||||||
[PR #181](https://github.com/fivetran/dbt_zendesk/pull/181) includes the following updates: | ||||||
|
||||||
## New Features | ||||||
- Introduced new config variables `using_brands` and `using_organizations` to allow the customers to enable and disable `brand` and `organization` source data. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- End models that could be impacted by these variables include: | ||||||
- `zendesk__ticket_backlog`: `using_brands` and/or `using_organizations` can be set to `false` to disable `brand` and/or `organization` fields. | ||||||
- `zendesk__ticket_enriched`: `using_organizations` can be set to `false` to remove `organization` fields from the final model. | ||||||
- Intermediate models that could be impacted by these variables include: | ||||||
- `int_zendesk__organization_aggregates`: `using_organizations` can be utilized to completely disable the model. | ||||||
- `int_zendesk__ticket_aggregates`: `using_brands` can be set to `false` to remove `brand` fields from the final model. | ||||||
- `int_zendesk__updater_information`: `using_organizations` can be set to `false` to remove `organization` fields from the final model. | ||||||
|
||||||
## Under the Hood | ||||||
- Updated `table_variables` in the `quickstart.yml` with the new `brand` and `organization` tables. | ||||||
- Updated our Buildkite model run script to ensure we test for when `using_brands` and `using_organizations` is set to either true or false. | ||||||
|
||||||
## Documentation Updates | ||||||
- [Updated README](https://github.com/fivetran/dbt_zendesk?tab=readme-ov-file#step-4-enabledisable-models-for-non-existent-sources) with instructions on how to disable `brand` and `organization` sources. | ||||||
|
||||||
|
||||||
# dbt_zendesk v0.19.1 | ||||||
[PR #180](https://github.com/fivetran/dbt_zendesk/pull/180) includes the following update: | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -138,7 +138,7 @@ vars: | |
### Step 4: Enable/Disable models for non-existent sources | ||
|
||
> _This step is optional if you are unioning multiple connectors together in the previous step. The `union_data` macro will create empty staging models for sources that are not found in any of your Zendesk schemas/databases. However, you can still leverage the below variables if you would like to avoid this behavior._ | ||
This package takes into consideration that not every Zendesk Support account utilizes the `schedule`, `schedule_holiday`, `ticket_schedule`, `daylight_time`, `time_zone`, `audit_log`, `domain_name`, `user_tag`, `organization_tag`, or `ticket_form_history` features, and allows you to disable the corresponding functionality. By default, all variables' values are assumed to be `true`, except for `using_schedule_histories`. Add variables for only the tables you want to enable/disable: | ||
This package takes into consideration that not every Zendesk Support account utilizes the `schedule`, `schedule_holiday`, `ticket_schedule`, `daylight_time`, `time_zone`, `audit_log`, `domain_name`, `user_tag`, `brand`,`organization`, `organization_tag`, or `ticket_form_history` features, and allows you to disable the corresponding functionality. By default, all variables' values are assumed to be `true`, except for `using_schedule_histories`. Add variables for only the tables you want to enable/disable: | ||
```yml | ||
vars: | ||
using_schedule_histories: True #Enable if you are using audit_logs for schedule histories | ||
|
@@ -147,6 +147,8 @@ vars: | |
using_domain_names: False #Disable if you are not using domain names | ||
using_user_tags: False #Disable if you are not using user tags | ||
using_ticket_form_history: False #Disable if you are not using ticket form history | ||
using_brands: False #Disable if you are not using brands | ||
using_organizations: False #Disable if you are not using organizations | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same callout as in source about also adding a note for |
||
using_organization_tags: False #Disable if you are not using organization tags | ||
``` | ||
|
||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reminder to up the version |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wondering what this change was for and if we need to document this in the changelog? |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Believe we also need to add
organization_tag
here