Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Quickstart update #185

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Jan 8, 2025

PR Overview

This PR will address the following Issue/Feature: [#184]

This PR will result in the following new package version: 0.19.3

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Quickstart Update

  • Removed organization from using_organization_tags configuration to maintain a one-to-one mapping between a Quickstart source table and whether its corresponding variable in the models should be enabled or disabled.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • [NA] dbt run –full-refresh && dbt test
  • [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • [NA] Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Since no models are being updated, validation wasn't needed here

If you had to summarize this PR in an emoji, which would it be?

🤦🏽

@fivetran-avinash fivetran-avinash self-assigned this Jan 8, 2025
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one small note to add to the CHANGELOG.

CHANGELOG.md Show resolved Hide resolved
@fivetran-avinash fivetran-avinash merged commit be1ba2f into main Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Quickstart] Remove organization from using_organization_tags config in quickstart.yml
3 participants