doc(fivetran_sdk): Updated development guide for partners #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manjutapali
reviewed
Jun 12, 2024
Co-authored-by: Alex Ilyichov <[email protected]>
Co-authored-by: Alex Ilyichov <[email protected]>
Co-authored-by: Alex Ilyichov <[email protected]>
Co-authored-by: Alex Ilyichov <[email protected]>
Co-authored-by: Alex Ilyichov <[email protected]>
Co-authored-by: Alex Ilyichov <[email protected]>
Co-authored-by: Alex Ilyichov <[email protected]>
ediril
requested changes
Jun 18, 2024
Co-authored-by: Emrah Diril <[email protected]>
Co-authored-by: Emrah Diril <[email protected]>
Co-authored-by: Emrah Diril <[email protected]>
Co-authored-by: Emrah Diril <[email protected]>
Co-authored-by: Emrah Diril <[email protected]>
Co-authored-by: Emrah Diril <[email protected]>
ediril
approved these changes
Jun 19, 2024
fivetran-abdulsalam
suggested changes
Jun 21, 2024
Co-authored-by: Abdul Salam <[email protected]>
|
|
||
| - `update_files` is for `update` operation where modified columns have actual values whereas unmodified columns have the special value `unmodified_string` in `CsvFileParams`. Soft-deleted rows will arrive in here as well. Update the `_fivetran_synced` column in the destination with the values coming in from the csv files. | ||
| - `update_files` is for the `update` operation where modified columns have actual values whereas unmodified columns have the special value `unmodified_string` in `FileParams`. Soft-deleted rows will arrive in here as well. Update the `_fivetran_synced` column in the destination with the values coming in from the batch files. |
There was a problem hiding this comment.
Note: I will merging the CsvFileParams and ParquetFileParams into one i.e. FileParams.
Ref: https://fivetran.height.app/T-725623
| - `keys` is a map that provides a list of secret keys, one for each batch file, that can be used to decrypt them. | ||
|
|
||
| - `file_params` provides information about the file type and any configurations applied to it, such as encryption or compression. | ||
|
|
||
| Also, Fivetran will deduplicate operations such that each primary key will show up only once in any of the operations | ||
|
|
||
| Do not assume order of columns in the batch files. Always read the CSV file header to determine column order. |
There was a problem hiding this comment.
Suggested change
| Do not assume order of columns in the batch files. Always read the CSV file header to determine column order. | |
| Do not assume order of columns in the batch files. Always read the columns of batch file to determine column order. |
fivetran-abdulsalam
approved these changes
Jun 24, 2024
|
Related PR: #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://fivetran.height.app/T-711151
Description of Changes
Updated development guide for partners