Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/explicit duration list #111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

philomory
Copy link

This attempts to address #110 in a slightly more thorough way, allowing users who wish to exceed 48 hours as their max duration to do so by specifying an explicit list of values to supply in the drop down; it also has the side effect of allowing people who are fine with 48 hours or less to trim their list by omitting some of the increments.

Example usage:

module "aws_sso_elevator {
  source  = "fivexl/sso-elevator/aws"
  version = "3.0.0"

  ...
  permission_duration_list_override = ["00:30","01:00","02:00","03:00","06:00","12:00","24:00","48:00","72:00","96:00"]
  ... 
}

Resulting display:
image

I think it might have been even nicer to allow specifying times with e.g. "1h30m", but, this method was simpler to integrate into the existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant