Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the handling of msg.signer in contracts #62

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Fixing the handling of msg.signer in contracts #62

merged 9 commits into from
Jan 30, 2024

Conversation

fjarri
Copy link
Collaborator

@fjarri fjarri commented Jan 30, 2024

... and all the related issues that popped up:

  • added AccountSigner.private_key property
  • added LocalProvider.add_account() method
  • added an optional sender_address parameter of ClientSession.eth_call()
  • AccountSigner now takes LocalSigner specifically and not just any BaseSigner
  • ClientSession.estimate_transact() and estimate_deploy() now require a sender_address

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85a956c) 100.00% compared to head (1324e2d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         2018      2024    +6     
  Branches       335       336    +1     
=========================================
+ Hits          2018      2024    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjarri fjarri merged commit a2022b8 into master Jan 30, 2024
11 checks passed
@fjarri fjarri deleted the msg-signer branch January 30, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant