Skip to content

Commit

Permalink
Enable to set JSON endpoints to "none" timetheoretical#61 timetheoret…
Browse files Browse the repository at this point in the history
…ical#70 timetheoretical#72 timetheoretical#74

When a local installation does not provide Dial-in access, there is no need for listing phone numbers and conference PINs. Both lists usually are gathered by
- CONFERENCEMAPPER_ENDPOINT
- PHONENUMBERLIST_ENDPOINT
Enable a value of "none" in the installer to skip trying to retrieve the numbers and PINs
  • Loading branch information
Achim Leitner committed May 8, 2023
1 parent 960c842 commit 97972b5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 6 additions & 0 deletions JitsiMeetOutlook/JitsiApiService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ public JitsiApiService() {

public async Task<string> getPIN(string roomName)
{
if (Properties.Settings.Default.conferenceMapperEndpoint.ToLower() == "none") {
return "";
}
string conferenceMapperRequestUrl = $"{Properties.Settings.Default.conferenceMapperEndpoint}?conference={roomName}@conference.{JitsiUrl.getDomain()}";

try
Expand All @@ -58,6 +61,9 @@ public async Task<string> getPIN(string roomName)

public async Task<PhoneNumberListResponse> getPhoneNumbers(string roomName)
{
if (Properties.Settings.Default.phoneNumberListEndpoint.ToLower() == "none") {
return new PhoneNumberListResponse { Numbers = new Dictionary<string, List<string>>() };
}
string phoneNumberListRequestUrl = $"{Properties.Settings.Default.phoneNumberListEndpoint}?conference={roomName}@conference.{JitsiUrl.getDomain()}";
try
{
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ As of v0.4.0, the add-in can be installed via command line with custom setting p
- `NOAUDIO`: Mute audio by default in new Jitsi Meet appointments. (True/False)
- `NOVIDEO`: Disable video by default in new Jitsi Meet appointments. (True/False)
- `LANG`: Specify the display language. Currently, English, French, German, and Russian are available. (en/fr/de/ru)
- `CONFERENCEMAPPER_ENDPOINT`: Endpoint to get the Conference PIN from
- `PHONENUMBERLIST_ENDPOINT`: Endpoint to get the Phone Number from to call in
- `CONFERENCEMAPPER_ENDPOINT`: Endpoint to get the Conference PIN from. Set to "none" if dial-in is not supported.
- `PHONENUMBERLIST_ENDPOINT`: Endpoint to get the Phone Number from to call in. Set to "none" if dial-in is not supported.
- `CONFERENCESCHEDULER_ENDPOINT`: Endpoint to send the conference information to in advance, in order to make the call available for call in before the first person joins
- `CONFERENCESCHEDULER_ENDPOINT_SECRET`: Secret for the `CONFERENCESCHEDULER_ENDPOINT`, used for JWT generation.

Expand Down

0 comments on commit 97972b5

Please sign in to comment.