Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for single file analysis (update) #1252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Aug 29, 2024

  • makes intercom backend listener "responder" asynchronous (so it does not block when waiting for the result)

  • converts the "single file analysis task" listener into a responder

  • changes the show analysis page so that single file analyses are awaited and the page is automatically reloaded

  • adds a button to the "analysis is outdated" message to quickly update it

  • based on intercom backend refactoring: make data flow comprehensible #1251 so that one should be merged first

@jstucke jstucke requested review from dorpvom and maringuu August 29, 2024 08:26
@jstucke jstucke self-assigned this Aug 29, 2024
@jstucke jstucke force-pushed the quick-update-outdated-analysis branch from b51d1e2 to a397a86 Compare August 29, 2024 08:28
also adds a button to the 'analysis is outdated' message to update it
@jstucke jstucke force-pushed the quick-update-outdated-analysis branch from a397a86 to c3fb840 Compare December 3, 2024 16:37
@jstucke jstucke marked this pull request as ready for review December 3, 2024 16:37
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.87%. Comparing base (bd5bdb0) to head (c3fb840).

Files with missing lines Patch % Lines
src/scheduler/analysis/scheduler.py 50.00% 4 Missing ⚠️
src/intercom/back_end_binding.py 95.83% 1 Missing ⚠️
src/web_interface/components/analysis_routes.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
- Coverage   92.21%   91.87%   -0.35%     
==========================================
  Files         377      376       -1     
  Lines       23068    20990    -2078     
==========================================
- Hits        21273    19285    -1988     
+ Misses       1795     1705      -90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants