cancel analysis

[jstucke]

• new feature: cancel analyses that are currently in progress (also works with updates)
  • analyses and extractions that are currently underway will not be canceled
  • instead, following analyses and extractions will not be scheduled
  • can be triggered on the "system health" page in the web interface (REST: TODO)

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 95.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (bd5bdb0) to head (2679946).

Files with missing lines	Patch %	Lines
src/intercom/back_end_binding.py	57.14%	3 Missing ⚠️
src/scheduler/analysis/scheduler.py	50.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
- Coverage   92.21%   91.93%   -0.29%     
==========================================
  Files         377      376       -1     
  Lines       23068    21047    -2021     
==========================================
- Hits        21273    19350    -1923     
+ Misses       1795     1697      -98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maringuu]

How can analysis be resumed?
Would I have to hit the re-analyze button?

Also, I think there needs to be an endpoint in the rest API to cancel an anylsis.
Furthermore, I think it should be queryable whether an analysis was canceled.
If., e.g., analyzing LFwC which contains thousands of firmware images and I canceled some of them, I would want to exclude them from my farther evaluation.

[maringuu]

Should these be private?

[jstucke]

yes -> fixed

[maringuu]

In the future please, create a separate commit for (unrelated) formatting changes.
Having them in the same commit makes reviewing harder as you have to deliberatly ignore some parts of the code but not all ofc.

[jstucke]

How can analysis be resumed?

The analysis cannot be resumed. The files were dropped from scheduling at that point (it would not really be feasible to keep them lying around somewhere for when we might need them again (if that ever happens))

Would I have to hit the re-analyze button?

You would have to use "Redo analysis" as there is currently no way to tell which files were fully extracted/analyzed. We could consider adding some kind of flag to the metadata which could also be displayed in the web interface.

Also, I think there needs to be an endpoint in the rest API to cancel an anylsis.

Yes, that is planned (but in another PR)

Furthermore, I think it should be queryable whether an analysis was canceled.

There should be a new entry recently_canceled_analyses in the status data, so this should be possible already (the FW will be automatically removed from this data after the configured time, though (just like the "recently_finished_analyses"))