Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for cve_lookup installation RAM usage #1306

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Nov 27, 2024

  • stream all data during cve_lookup installation in order to fix RAM issues on the CI
  • also: refactor bulky add_cve_items method (which got even larger because of the changes)

@jstucke jstucke self-assigned this Nov 27, 2024
@jstucke jstucke force-pushed the cve-lookup-install-ram-fix branch 3 times, most recently from c1c53fa to 27d81e3 Compare November 27, 2024 10:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 68.08511% with 15 lines in your changes missing coverage. Please review.

Project coverage is 91.80%. Comparing base (2aa83a0) to head (573d6be).

Files with missing lines Patch % Lines
...ugins/analysis/cve_lookup/internal/data_parsing.py 38.09% 13 Missing ⚠️
.../analysis/cve_lookup/internal/database/db_setup.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
- Coverage   92.34%   91.80%   -0.55%     
==========================================
  Files         379      378       -1     
  Lines       23465    20986    -2479     
==========================================
- Hits        21669    19266    -2403     
+ Misses       1796     1720      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

in order to fix RAM issues on the CI
which got even larger because of the RAM fix
@jstucke jstucke force-pushed the cve-lookup-install-ram-fix branch from 27d81e3 to 573d6be Compare December 11, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants