Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browse comparisons view #1318

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

dorpvom
Copy link
Member

@dorpvom dorpvom commented Dec 13, 2024

A real update might come later, but for now just using the slightly nicer listing from the home / dashboard page to be more consistent with general fact look.

@dorpvom dorpvom added the gui label Dec 13, 2024
@dorpvom dorpvom requested a review from jstucke December 13, 2024 08:29
@dorpvom dorpvom self-assigned this Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (2aa83a0) to head (ab93736).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
- Coverage   92.34%   91.84%   -0.50%     
==========================================
  Files         379      378       -1     
  Lines       23465    20981    -2484     
==========================================
- Hits        21669    19271    -2398     
+ Misses       1796     1710      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jstucke jstucke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but maybe I'm biased 😅

Copy link
Collaborator

@euwint euwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it looks good.

@jstucke
Copy link
Collaborator

jstucke commented Jan 20, 2025

the noble CI worker only failed because of a bug with the package sources (which was fixed in the meantime). Shouldn't prevent us from merging I think

@dorpvom dorpvom merged commit ccb8283 into master Jan 21, 2025
9 of 10 checks passed
@dorpvom dorpvom deleted the update-template-of-comparison-browse branch January 21, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants