Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward to analysis page (missing analysis) #1320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Dec 16, 2024

  • if an analysis did not run for a file, the user is directed to an error page (a page empty except for an error message)
  • this is not helpful, so this PR changes this behavior as follows: Instead of showing the error page the user is forwarded back to the analysis page (without selected plugin) and the error is displayed as flash message
  • steps to (re)produce the error: Go to some file in a FW, run a "single file analysis" and go back to the root object through the link in the "general information" section

@jstucke jstucke added the gui label Dec 16, 2024
@jstucke jstucke self-assigned this Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (058e49f) to head (e52b4b5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
- Coverage   92.42%   91.85%   -0.58%     
==========================================
  Files         379      378       -1     
  Lines       23661    20982    -2679     
==========================================
- Hits        21869    19272    -2597     
+ Misses       1792     1710      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maringuu
Copy link
Collaborator

Please put the PR description in the commit message.
If you do this before opening the commit, GitHub will automatically use the commit message as PR description.

@maringuu maringuu self-requested a review December 18, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants