remove logaggregator

CHANGELOG.md

@@ -8,6 +8,8 @@
 * Fix writing time measurements into the event after the deleter has deleted the event. The bug only
 happened when the `metrics.measure_time.append_to_event` configuration was set to `true`.
 
+* Fix memory leak by removing the log aggregation capability
+
 ## v6.8.0
 ### Features
 

logprep/run_logprep.py

@@ -16,7 +16,6 @@
 from logprep._version import get_versions
 from logprep.processor.base.rule import Rule
 from logprep.runner import Runner
-from logprep.util.aggregating_logger import AggregatingLogger
 from logprep.util.auto_rule_tester.auto_rule_corpus_tester import RuleCorpusTester
 from logprep.util.auto_rule_tester.auto_rule_tester import AutoRuleTester
 from logprep.util.configuration import Configuration, InvalidConfigurationError
@@ -25,6 +24,14 @@
 from logprep.util.schema_and_rule_checker import SchemaAndRuleChecker
 from logprep.util.time_measurement import TimeMeasurement
 
+from logging import (
+    getLogger,
+    basicConfig,
+    Logger,
+)
+from logging.handlers import SysLogHandler
+
+
 warnings.simplefilter("always", DeprecationWarning)
 logging.captureWarnings(True)
 
@@ -137,10 +144,15 @@ def get_versions_string(args) -> str:
     return version_string
 
 
-def _setup_logger(args, config):
+def _setup_logger(args, config: Configuration):
     try:
-        AggregatingLogger.setup(config, logger_disabled=args.disable_logging)
-        logger = AggregatingLogger.create("Logprep")
+        log_config = config.get("logger", {})
+        log_level = log_config.get("level", "INFO")
+        basicConfig(
+            level=log_level, format="%(asctime)-15s %(name)-5s %(levelname)-8s: %(message)s"
+        )
+        logger = logging.getLogger("Logprep")
+        logger.info(f"Log level set to '{log_level}'")
         for version in get_versions_string(args).split("\n"):
             logger.info(version)
     except BaseException as error:  # pylint: disable=broad-except

logprep/runner.py

@@ -184,6 +184,7 @@ def start(self):
             self._continue_iterating.value = True
         self._schedule_config_refresh_job()
         self._logger.info("Startup complete")
+        self._logger.debug("Runner iterating")
         for _ in self._keep_iterating():
             self._loop()
         self.stop()
@@ -194,7 +195,6 @@ def start(self):
 
     def _loop(self):
         self.scheduler.run_pending()
-        self._logger.debug("Runner iterating")
         self._manager.restart_failed_pipeline()
         # Note: We are waiting half the timeout because when shutting down, we also have to
         # wait for the logprep's timeout before the shutdown is actually initiated.

tests/unit/test_run_logprep.py

@@ -233,7 +233,7 @@ def test_main_calls_runner_stop_on_any_exception(self, mock_stop, mock_start):
         mock_stop.assert_called()
 
     def test_logprep_exits_if_logger_can_not_be_created(self):
-        with mock.patch("logprep.run_logprep.AggregatingLogger.create") as mock_create:
+        with mock.patch("logging.getLogger") as mock_create:
             mock_create.side_effect = BaseException
             config_path = "quickstart/exampledata/config/pipeline.yml"
             with mock.patch("sys.argv", ["logprep", config_path]):