-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite kafka connector #444
Conversation
a6169c0
to
73c8d9b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
+ Coverage 91.97% 92.01% +0.03%
==========================================
Files 132 132
Lines 9389 9476 +87
==========================================
+ Hits 8636 8719 +83
- Misses 753 757 +4
☔ View full report in Codecov by Sentry. |
4402f56
to
eae00ea
Compare
5128344
to
9f7facd
Compare
rebased from main. @ppcad now it`s ready to rumble 👍 |
9f7facd
to
724f31d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever group.id
is missing from the kafka_config
the error message is Required option is missing: input
instead of telling what is missing.
Whenever bootstrap.servers
is missing from the kafka_config
Logprep crashes with a stacktrace.
group: "cgroup"
in the confluent_kafka input example should be updated to group.id: "cgroup"
.
I have ran a couple of tests to compare it with the old version. I used the same config parameters. I activated only the labeler with no rules. In that case, the new version was about 25% slower than the old version. Do you have an idea why that could be?
it is possible, that the |
I added a validation for mandatory keys in kafka_config object. This prevents the Exceptions during start and logs the missing keys. |
cb5d712
to
6a036bd
Compare
Thanks for the changes. This solves the problem. |
This does not seem to be the reason for the performance loss. It seems that the new version is faster than the old one with 1 process, but slower once I increase the amount up to the partition count. |
this PR rewrites the confluent kafka input and output processors with focus on the input side.
please take a look at the CHANGELOG.md for changes.