Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MetricFileTarget #456

Merged
merged 8 commits into from
Oct 9, 2023
Merged

Remove MetricFileTarget #456

merged 8 commits into from
Oct 9, 2023

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Oct 9, 2023

No description provided.

@ekneg54 ekneg54 self-assigned this Oct 9, 2023
@ekneg54 ekneg54 requested a review from dtrai2 October 9, 2023 13:45
@ekneg54 ekneg54 marked this pull request as ready for review October 9, 2023 13:45
@ekneg54 ekneg54 added the refactoring only refactoring, no change in behavior label Oct 9, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e5cbb34) 92.29% compared to head (bbb47f5) 92.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   92.29%   92.10%   -0.19%     
==========================================
  Files         135      134       -1     
  Lines        9562     9461     -101     
==========================================
- Hits         8825     8714     -111     
- Misses        737      747      +10     
Files Coverage Δ
logprep/framework/pipeline.py 97.22% <100.00%> (+<0.01%) ⬆️
logprep/framework/pipeline_manager.py 100.00% <100.00%> (ø)
logprep/metrics/metric.py 100.00% <100.00%> (ø)
logprep/util/prometheus_exporter.py 95.34% <100.00%> (-4.66%) ⬇️
logprep/runner.py 96.52% <66.66%> (-0.72%) ⬇️
logprep/util/configuration.py 95.90% <90.00%> (-0.90%) ⬇️
logprep/metrics/metric_exposer.py 86.31% <43.47%> (-13.69%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekneg54 ekneg54 merged commit 02448cd into main Oct 9, 2023
10 checks passed
@ekneg54 ekneg54 deleted the refactor-metrics branch October 9, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring only refactoring, no change in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants