Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to ignore missing fields in field_manager #457

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Oct 9, 2023

this adds an option of ignoring missing source fields for some processors and tests for a bug that processing does not continue if a source_field is missing

@ekneg54 ekneg54 added the enhancement New feature or request label Oct 9, 2023
@ekneg54 ekneg54 requested a review from dtrai2 October 9, 2023 16:18
@ekneg54 ekneg54 self-assigned this Oct 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (eb4db4b) 91.91% compared to head (9ccc64f) 92.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   91.91%   92.03%   +0.11%     
==========================================
  Files         132      132              
  Lines        9476     9505      +29     
==========================================
+ Hits         8710     8748      +38     
+ Misses        766      757       -9     
Files Coverage Δ
logprep/abc/processor.py 99.42% <100.00%> (+<0.01%) ⬆️
logprep/processor/amides/rule.py 100.00% <100.00%> (ø)
logprep/processor/calculator/rule.py 100.00% <100.00%> (ø)
logprep/processor/concatenator/processor.py 94.11% <100.00%> (+0.36%) ⬆️
logprep/processor/datetime_extractor/rule.py 100.00% <100.00%> (ø)
logprep/processor/dissector/processor.py 100.00% <100.00%> (ø)
logprep/processor/domain_label_extractor/rule.py 100.00% <100.00%> (ø)
logprep/processor/domain_resolver/rule.py 100.00% <100.00%> (ø)
logprep/processor/field_manager/processor.py 100.00% <100.00%> (ø)
logprep/processor/field_manager/rule.py 95.34% <100.00%> (+0.47%) ⬆️
... and 11 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekneg54 ekneg54 force-pushed the feature-field-manager-ignore-missing-fields-option branch from 2a91f2b to 64d47d0 Compare October 9, 2023 20:22
logprep/processor/grokker/processor.py Outdated Show resolved Hide resolved
logprep/processor/string_splitter/rule.py Show resolved Hide resolved
logprep/processor/timestamp_differ/rule.py Show resolved Hide resolved
logprep/processor/timestamper/rule.py Show resolved Hide resolved
tests/unit/processor/concatenator/test_concatenator.py Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@ekneg54 ekneg54 requested a review from dtrai2 October 10, 2023 17:44
logprep/processor/calculator/rule.py Outdated Show resolved Hide resolved
logprep/processor/string_splitter/rule.py Show resolved Hide resolved
logprep/processor/timestamper/rule.py Show resolved Hide resolved
@ekneg54 ekneg54 requested a review from dtrai2 October 12, 2023 07:26
@ekneg54 ekneg54 force-pushed the feature-field-manager-ignore-missing-fields-option branch from 17b4760 to 9ccc64f Compare October 13, 2023 07:47
@ekneg54 ekneg54 merged commit c67124c into main Oct 13, 2023
10 checks passed
@ekneg54 ekneg54 deleted the feature-field-manager-ignore-missing-fields-option branch October 13, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants