-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to ignore missing fields in field_manager #457
Merged
ekneg54
merged 6 commits into
main
from
feature-field-manager-ignore-missing-fields-option
Oct 13, 2023
Merged
add option to ignore missing fields in field_manager #457
ekneg54
merged 6 commits into
main
from
feature-field-manager-ignore-missing-fields-option
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
+ Coverage 91.91% 92.03% +0.11%
==========================================
Files 132 132
Lines 9476 9505 +29
==========================================
+ Hits 8710 8748 +38
+ Misses 766 757 -9
☔ View full report in Codecov by Sentry. |
ekneg54
force-pushed
the
feature-field-manager-ignore-missing-fields-option
branch
from
October 9, 2023 20:22
2a91f2b
to
64d47d0
Compare
dtrai2
requested changes
Oct 10, 2023
dtrai2
requested changes
Oct 12, 2023
Co-authored-by: dtrai2 <[email protected]>
ekneg54
force-pushed
the
feature-field-manager-ignore-missing-fields-option
branch
from
October 13, 2023 07:47
17b4760
to
9ccc64f
Compare
dtrai2
approved these changes
Oct 13, 2023
ekneg54
deleted the
feature-field-manager-ignore-missing-fields-option
branch
October 13, 2023 07:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds an option of ignoring missing source fields for some processors and tests for a bug that processing does not continue if a source_field is missing