Add Flush Timeout to s3 Connector #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make `_s3_resource` a cached property. * Move s3 session and resource creation into `setup()` method so that task for `flush_timeout` can be scheduled properly.
* Adapt task scheduling unit test to not interfere with local opensearch instance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
+ Coverage 94.39% 94.44% +0.04%
==========================================
Files 144 143 -1
Lines 10047 10075 +28
==========================================
+ Hits 9484 9515 +31
+ Misses 563 560 -3 ☔ View full report in Codecov by Sentry. |
ekneg54
approved these changes
Apr 25, 2024
ekneg54
requested changes
Apr 25, 2024
* Make `_build_no_prefix_document` non-static and use internal `_encoder` to encode document
ekneg54
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
flush_timeoutconfiguration option to theS3Outputconnector.When the specified
flush_timeoutinterval expires, the s3 connector will write all backlog elements, regardless whether the message backlog is actually full or not.This prevents the connector from holding onto logs forever, if there are no new logs to process and the configured backlog size is not reached.
Changelog:
flush_timeoutconfiguration option for theS3Outputconnectorsetupmethod where_write_backlogis scheduled_s3_resourcea cached propertysetupmethod to check whether the specifiedbucketis accessible_handle_s3_errordecorator to handle all boto3 and boto-core related exceptions.