Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overview with best practices to docs #559

Merged
merged 17 commits into from
Apr 19, 2024

Conversation

dtrai2
Copy link
Collaborator

@dtrai2 dtrai2 commented Apr 5, 2024

No description provided.

dtrai2 added 2 commits April 5, 2024 15:48
as it is already described inside the configuration documentation.
Allows new admonitions and a combined list of them. Derived from sphinx ToDo extension example.
@dtrai2 dtrai2 added the documentation Improvements or additions to documentation label Apr 5, 2024
@dtrai2 dtrai2 self-assigned this Apr 5, 2024
@dtrai2 dtrai2 requested a review from herrfeder April 9, 2024 09:35
Copy link
Collaborator

@herrfeder herrfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand how the excel build is triggered from the sphinx config but it works and looks fine. Really great work. Maybe already a bit overengineered for a first implementation xD

Copy link
Collaborator

@herrfeder herrfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The necessary CHANGELOG.md entry is missing.

@herrfeder herrfeder self-assigned this Apr 19, 2024
@herrfeder herrfeder marked this pull request as ready for review April 19, 2024 08:34
@herrfeder herrfeder merged commit dff0776 into main Apr 19, 2024
10 checks passed
@herrfeder herrfeder deleted the dev-add-best-practices-to-docs branch April 19, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants