Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make configuration immutable #661

Merged
merged 17 commits into from
Sep 10, 2024
Merged

make configuration immutable #661

merged 17 commits into from
Sep 10, 2024

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Aug 31, 2024

closes #660

@ekneg54 ekneg54 added the bug Something isn't working label Aug 31, 2024
@ekneg54 ekneg54 self-assigned this Aug 31, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (1ef1b78) to head (8e4bf4b).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   94.44%   94.35%   -0.09%     
==========================================
  Files         147      147              
  Lines        9926    10034     +108     
==========================================
+ Hits         9375     9468      +93     
- Misses        551      566      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekneg54 ekneg54 marked this pull request as ready for review September 6, 2024 13:07
@ekneg54 ekneg54 requested a review from djkhl September 6, 2024 13:08
Copy link
Collaborator

@djkhl djkhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding everything looks good and works as expected. The only thing i saw is one unsued import. I don't know if you wanted to add more tests to check for this error.

tests/unit/util/test_configuration.py Outdated Show resolved Hide resolved
@ekneg54 ekneg54 requested a review from djkhl September 10, 2024 09:53
@ekneg54 ekneg54 force-pushed the fix-frozen-configuration branch from 4f14da8 to 996407b Compare September 10, 2024 09:53
@ekneg54 ekneg54 merged commit feb5ca0 into main Sep 10, 2024
12 checks passed
@ekneg54 ekneg54 deleted the fix-frozen-configuration branch September 10, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration is not immutable and can't be applied multiple times
3 participants