-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make configuration immutable #661
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
- Coverage 94.44% 94.35% -0.09%
==========================================
Files 147 147
Lines 9926 10034 +108
==========================================
+ Hits 9375 9468 +93
- Misses 551 566 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my understanding everything looks good and works as expected. The only thing i saw is one unsued import. I don't know if you wanted to add more tests to check for this error.
4f14da8
to
996407b
Compare
closes #660