Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up exporter tests #705

Merged
merged 4 commits into from
Nov 14, 2024
Merged

speed up exporter tests #705

merged 4 commits into from
Nov 14, 2024

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Nov 12, 2024 •
edited
Loading

test with:

pytest ./tests/unit/metrics/test_exporter.py -vv --durations=10 --durations-min=1.0

before (main)
image

after
image

additionally the risk of deadlocks are reduced by not spinning up threads or processes during unittests

@ekneg54 ekneg54 added the refactoring only refactoring, no change in behavior label Nov 12, 2024
@ekneg54 ekneg54 self-assigned this Nov 12, 2024
@ekneg54
refactor health endpoint tests
52a8a33 
* move http endpoint test as smoke test to the acceptance tests
* use asgiref testing to test only the asgi app in unittests
@ekneg54
remove redundant init call
8fde055
@ekneg54 ekneg54 requested a review from dtrai2 November 12, 2024 12:58
@ekneg54 ekneg54 marked this pull request as ready for review November 12, 2024 13:08
@ekneg54 ekneg54 merged commit 50ee02e into main Nov 14, 2024
13 checks passed
@ekneg54 ekneg54 deleted the dev-speedup-metrics-tests branch November 14, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtrai2 dtrai2 dtrai2 approved these changes

Assignees

@ekneg54 ekneg54

Labels
refactoring only refactoring, no change in behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekneg54 @dtrai2