Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up s3 output tests #706

Merged
merged 1 commit into from
Nov 13, 2024
Merged

speed up s3 output tests #706

merged 1 commit into from
Nov 13, 2024

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Nov 12, 2024

easy win 🥇
we ensure not calling out to dns resolver

test with:

pytest ./tests/unit/connector/test_s3_output.py -vv --durations=10 --durations-min=1.0

before (main)

image

after

image

@ekneg54 ekneg54 added the refactoring only refactoring, no change in behavior label Nov 12, 2024
@ekneg54 ekneg54 requested a review from dtrai2 November 12, 2024 13:19
@ekneg54 ekneg54 self-assigned this Nov 12, 2024
@ekneg54 ekneg54 merged commit 5c45241 into main Nov 13, 2024
13 checks passed
@ekneg54 ekneg54 deleted the dev-speedup-s3-output-tests branch November 13, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtrai2 dtrai2 dtrai2 approved these changes

Assignees

@ekneg54 ekneg54

Labels
refactoring only refactoring, no change in behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekneg54 @dtrai2