Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up s3 output tests #706

Merged
merged 1 commit into from
Nov 13, 2024
Merged

speed up s3 output tests #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/unit/connector/test_s3_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
# pylint: disable=attribute-defined-outside-init
import logging
from copy import deepcopy
from datetime import datetime
from math import isclose
from unittest import mock

import pytest
Expand All @@ -30,7 +28,7 @@ class NotJsonSerializableMock:
class TestS3Output(BaseOutputTestCase):
CONFIG = {
"type": "s3_output",
"endpoint_url": "http://host:123",
"endpoint_url": "http://localhost:23423",
"aws_access_key_id": "foo_aws_access_key_id",
"aws_secret_access_key": "foo_aws_secret_access_key",
"bucket": "foo_bucket",
Expand All @@ -50,7 +48,8 @@ class TestS3Output(BaseOutputTestCase):

def test_describe_returns_s3_output(self):
assert (
self.object.describe() == "S3Output (Test Instance Name) - S3 Output: http://host:123"
self.object.describe()
== "S3Output (Test Instance Name) - S3 Output: http://localhost:23423"
)

base_prefix_tests_cases = ["", "test"]
Expand Down
Loading