Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter matching with bypass tree #719

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Fix filter matching with bypass tree #719

merged 3 commits into from
Dec 5, 2024

Conversation

ppcad
Copy link
Collaborator

@ppcad ppcad commented Dec 5, 2024

No description provided.

@ppcad ppcad requested a review from ekneg54 December 5, 2024 10:34
@ppcad ppcad self-assigned this Dec 5, 2024
@ppcad ppcad linked an issue Dec 5, 2024 that may be closed by this pull request
Bypass rule tree error #709
Closed
ekneg54
ekneg54 requested changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@ekneg54 ekneg54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you investigate a litte bit deeper?

logprep/filter/expression/filter_expression.py Outdated Show resolved Hide resolved
@ppcad ppcad requested a review from ekneg54 December 5, 2024 11:57
@ekneg54 ekneg54 merged commit ac2b2f8 into main Dec 5, 2024
13 checks passed
@ekneg54 ekneg54 deleted the fix-filter-matching-with-bypass-tree branch December 5, 2024 12:57
@ppcad
Copy link
Collaborator Author

ppcad commented Dec 6, 2024

I also want to clarify why this problem doesn't occur with the tree.
The tree does first check with an Exists filter expression for existence before it applies a KeyValueBasedFilterExpression.
The Exists filter expression uses a different method for matching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekneg54 ekneg54 ekneg54 approved these changes

Assignees

@ppcad ppcad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bypass rule tree error
2 participants
@ppcad @ekneg54