Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff #147

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Ruff #147

merged 2 commits into from
Aug 22, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Aug 8, 2024

replaced all python linters and formatters with ruff

@jstucke jstucke requested a review from maringuu August 8, 2024 16:12
@jstucke jstucke self-assigned this Aug 8, 2024
Copy link
Collaborator

@maringuu maringuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I still have some comments.
Also, please add a commit that makes pre-commit run --all-files pass.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@jstucke
Copy link
Collaborator Author

jstucke commented Aug 15, 2024

Nice! I still have some comments. Also, please add a commit that makes pre-commit run --all-files pass.

In a different PR. This one is big enough as it is. What is more, the option --from-ref ${{ github.event.pull_request.base.sha }} --to-ref ${{ github.event.pull_request.head.sha }} in the Github action makes pre-commit only run on the changes and not all files (which is more useful IMHO)

pyproject.toml Outdated Show resolved Hide resolved
@maringuu maringuu merged commit 92288e3 into master Aug 22, 2024
2 checks passed
@maringuu maringuu deleted the ruff branch August 22, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants