Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic for reminder generation #219
Add logic for reminder generation #219
Changes from 3 commits
29e947e
5ed3972
f745895
4489eb6
000e1aa
adccafb
e76d759
2d2e6ad
ef788ca
1bcc255
e12885a
7a6b8ed
6374582
e2c5b00
d49b802
6b24e4c
c059462
9072a3a
ff1df3e
7b987a9
f0c7a80
58753de
0329955
3553315
4179a8c
1d20f78
a2445c6
630d85a
764d7a9
428c193
e7dab81
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic to determine the
$client_class
based on$kind
is hardcoded for reminders, which limits extensibility. Consider using a dynamic approach to support more kinds in the future without modifying this code.This change makes the selection of the PDF builder class more flexible and easier to extend with additional types of PDFs in the future.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider revising the punctuation and spacing around the question marks to maintain consistency and adhere to standard English grammar rules. Specifically, remove the space before the question mark and consider adding a comma for clarity if intended to indicate a pause in casual speech.