Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add very basic benchmark infrastructure #3431

Merged
merged 4 commits into from
Jan 7, 2025
Merged

test: Add very basic benchmark infrastructure #3431

merged 4 commits into from
Jan 7, 2025

Conversation

luanpotter
Copy link
Member

Description

Add very basic benchmark infrastructure, using the examples app as a centralized benchmark playground and with first ever benchmark file just testing some components and updates (more to come).

This also sets up the dart-benchmark-action to run, starting on this very PR!

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Copy link
Contributor

github-actions bot commented Jan 5, 2025

Benchmark Results

Package flame:

  • Current Branch [luan.benchmark]: 2627.861 μs
  • Base Branch [main]: [-]
  • Diff: [-]

Benchmarks provided with 💙 by Dart Benchmark Action.

@spydon
Copy link
Member

spydon commented Jan 5, 2025

How did the pub get output get into the table? 😆

@luanpotter
Copy link
Member Author

Yeah, I guess melos add some extra output when running flutter test, which I failed to test...

Should be fixed on 0.1.13.

@luanpotter luanpotter marked this pull request as ready for review January 5, 2025 02:11
@luanpotter luanpotter requested a review from spydon January 5, 2025 14:47
@spydon spydon merged commit 4af202f into main Jan 7, 2025
9 checks passed
@spydon spydon deleted the luan.benchmark branch January 7, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants