Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use built-in camera in example #3458

Merged
merged 1 commit into from
Jan 26, 2025
Merged

docs: Use built-in camera in example #3458

merged 1 commit into from
Jan 26, 2025

Conversation

spydon
Copy link
Member

@spydon spydon commented Jan 26, 2025

Description

This uses the built-in camera in the example, so that people don't create new default cameras accidentally.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@spydon spydon enabled auto-merge (squash) January 26, 2025 16:00
@github-actions GitHub Actions
Copy link
Contributor

Benchmark Results

Package flame:

Benchmarks Current Branch
[docs/update-camera-component-example]		 Base Branch
[main]		 Diff
Render Components Benchmark 1193.361 μs 1199.415 μs 🟢 -0.505 %
Updating Components Benchmark 249381.111 μs 250008.778 μs 🟢 -0.251 %

Benchmarks provided with 💙 by Dart Benchmark Action.

@spydon spydon requested a review from erickzanardo January 26, 2025 16:16
@spydon spydon merged commit 13bb7cf into main Jan 26, 2025
9 checks passed
@spydon spydon deleted the docs/update-camera-component-example branch January 26, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @erickzanardo