Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: migrate all upload-artifact actions from v3 to v4 #3830

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

mmahmoudian
Copy link
Member

@mmahmoudian mmahmoudian commented Jan 31, 2025

The 4 failed CIs are irrelevant to this PR. The RPM CIs fail because this PR should be merged: #3685, and the Windows CI fails because of a python package which is not used by us. I think we should update the action there too, but that needs it's own PR.

@mmahmoudian mmahmoudian changed the title migrate all upload-artifact actions from v3 to v4 CI: migrate all upload-artifact actions from v3 to v4 Jan 31, 2025
@mmahmoudian
Copy link
Member Author

mmahmoudian commented Feb 3, 2025

Considering that

  1. this is non-destructive change and has nothing to do with our codebase (only updates the CI to bump the Action version)
  2. every other PR and our nightly builds are dependent on this one (because literally all the CIs are failing),
  3. it has been 3 days since I created the PR and no objections was raised (no approval from other devs either 🤷🏼 )

I will merge this PR to keep the ball rolling for the repo.

Please comment if you believe this is problematic PR or wrong in some way. it is very easy to roll back if needed.

@mmahmoudian mmahmoudian merged commit a1e5d2e into flameshot-org:master Feb 3, 2025
23 of 27 checks passed
@mmahmoudian mmahmoudian deleted the fix-ci branch February 3, 2025 13:12
@FelixJochems
Copy link

I overlooked this one on accident, but fully agree with your statement. No issues from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants