Verify that the request comes from GCP #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying GCP Pilot library requests that Google Cloud Tasks signs the request with an OIDC token, but there is no logic to check that in the view. This is a security vulnerability since the tasks can be run by anyone now.
|
Code Climate has analyzed commit aa9db5f and detected 0 issues on this pull request. View more on Code Climate. |
joaodaher
requested changes
Jan 17, 2025
There was a problem hiding this comment.
For setups that use private Cloud Run instances, the OIDC token is already validated by Cloud Run ingress [ref]. Adding a manual OIDC verification would be redundant.
Although I agree we should definitely allow manual checking for other uses cases, such as public Cloud Run instances. Thus, I'd suggest making this authentication opt-in using a setting (eg. DJANGO_CLOUD_TASKS_AUTH)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying GCP Pilot library requests that Google Cloud Tasks signs the request with an OIDC token, but there is no logic to check that in the view.
This is a security vulnerability since the tasks can be run by anyone now.