Fix sparse indexes when deleting #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermearaujo
force-pushed
the
gui-delete-sparse
branch
from
ddb8efc
to
a007311
Compare
joaodaher
reviewed
Jan 7, 2022
guilhermearaujo
force-pushed
the
gui-delete-sparse
branch
from
a007311
to
b848354
Compare
lucasgomide
approved these changes
Jan 19, 2022
joaodaher
requested changes
Jan 19, 2022
Comment on lines
+46
to
+55
| @receiver(post_delete) | ||
| def reorder_group(sender, instance, **kwargs): | ||
| from drf_kit.models import OrderedModelMixin # pylint: disable=import-outside-toplevel | ||
|
|
||
| if not issubclass(sender, OrderedModelMixin): | ||
| return | ||
|
|
||
| if previous := instance.previous(): | ||
| # trigger the reordering | ||
| previous.save() |
There was a problem hiding this comment.
You can register signals for all instances of this model instead of registering to all, and them filtering.
joaodaher
reviewed
Jan 19, 2022
| version = "1.9.0" | ||
| version = "1.10.0" |
joaodaher
reviewed
Jan 19, 2022
| @@ -458,3 +458,37 @@ def test_create_before_range(self): | |||
| self.assertOrder(placement_2, 2) | |||
| self.assertOrder(placement_3, 3) | |||
| self.assertOrder(placement_4, 0) | |||
|
|
|||
| def test_delete_within_range(self): | |||
There was a problem hiding this comment.
You can use factories now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.