Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize && operator precedence with extra brackets, as suggested by clang warning #1386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmikushin
Copy link
Contributor

Emphasize && operator precedence with extra brackets, as suggested by clang warning

@@ -404,7 +404,7 @@ tgt_target_fill_params(SPTR arg_base_sptr, SPTR arg_size_sptr, SPTR args_sptr,
chk_block(ilix);
} else {
/* Optimization - Pass by value for scalar */
if (TY_ISSCALAR(DTY(param_dtype)) && (targetinfo->symbols[i].map_type & OMP_TGT_MAPTYPE_IMPLICIT) || isMidnum || isThis ) {
if ((TY_ISSCALAR(DTY(param_dtype)) && (targetinfo->symbols[i].map_type & OMP_TGT_MAPTYPE_IMPLICIT)) || isMidnum || isThis ) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind wrapping the line to 80 columns as well?

@pawosm-arm pawosm-arm self-requested a review September 6, 2023 14:17
@bryanpkc
Copy link
Collaborator

@dmikushin gentle ping

@dmikushin
Copy link
Contributor Author

OK, I will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants