Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure/elemental violation detection #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pure/elemental violation detection #29

wants to merge 2 commits into from

Conversation

bolgrebolgre
Copy link

Changes in flang1:
(1) The severity was changed from 2 to 3 for pure attribute violation. (semant3.c, rest.c and semfin.c).
(2) A new error was added for the case when dummy arguments are not defined as intent(in) (semfin.c)
(3) A new error code 600 was added in errmsg-in.n for (2). The name of the dummy argument and the procedure who has violated the pure attribute are marked with color (brown-red).

Changes in runtime/flang/ieee_exception.F95 and ieee_arithmetic.F95 to remove pure/elemental violation errors during building process.

@bolgrebolgre
Copy link
Author

Made a change in semfin.c to allow value attribute in pure procedures without using intent(in).

@kiranchandramohan
Copy link
Collaborator

@bolgrebolgre Can you consider rebasing this PR and making it ready for a review?

@bolgrebolgre
Copy link
Author

@kiranchandramohan I will look into this. Would you mind if I start early next week? I am away from computer this week so probably difficult to work on this. Thanks!

@kiranchandramohan
Copy link
Collaborator

Thanks @bolgrebolgre for the reply. Yes, next week would be fine. We have a queue of PRs to review and work on. Was just going through the older PRs (like this one) to ensure they are also being considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants