[addon-operator] add module reregister #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miklezzzz
force-pushed
the
add-register-and-load-single-module
branch
26 times, most recently
from
20330ce to
a24a155
Compare
yalosev
reviewed
Dec 13, 2023
miklezzzz
force-pushed
the
add-register-and-load-single-module
branch
6 times, most recently
from
a38c103 to
bd87d5e
Compare
miklezzzz
force-pushed
the
add-register-and-load-single-module
branch
5 times, most recently
from
49657ca to
f2d803a
Compare
miklezzzz
force-pushed
the
add-register-and-load-single-module
branch
2 times, most recently
from
b2328ac to
d558146
Compare
miklezzzz
force-pushed
the
add-register-and-load-single-module
branch
2 times, most recently
from
474d7d1 to
ed207d9
Compare
yalosev
reviewed
Dec 27, 2023
| return false | ||
| } | ||
|
|
||
| return *moduleConfig.IsEnabled |
There was a problem hiding this comment.
IsEnabled could be nil. We have to add a check
yalosev
reviewed
Dec 27, 2023
| @@ -108,6 +117,24 @@ func (kcm *KubeConfigManager) KubeConfigEventCh() chan config.KubeConfigEvent { | |||
| return kcm.configEventCh | |||
| } | |||
|
|
|||
| // UpdateModuleConfig updates a single module config | |||
| func (kcm *KubeConfigManager) UpdateModuleConfig(moduleName string) error { | |||
| newConfig, err := kcm.backend.LoadConfig(kcm.ctx) | |||
There was a problem hiding this comment.
I think we have to add variadic parameter moduleName ...string to the LoadConfig function, to have ability to reload only desired ModuleConfig
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
miklezzzz
force-pushed
the
add-register-and-load-single-module
branch
from
ed207d9 to
74fdf90
Compare
yalosev
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes:
A lot of changes related to starting/restarting/disabling a module without restarting addon-operator.
What this PR does / why we need it
With this PR we can provide a way of reloading (restarting its life cycle like disabling and deregistering its hooks, reloading its configuration and re-run the module) a single module without restarting addon-operator.
Special notes for your reviewer