Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased CRDs Installer buffer size #522

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Increased CRDs Installer buffer size #522

merged 1 commit into from
Nov 7, 2024

Conversation

libmonsoon-dev
Copy link
Contributor

@libmonsoon-dev libmonsoon-dev commented Nov 7, 2024

Overview

Considering that etcd has a default value of 1.5Mb, it was decided to set it to 2Mb, so that in most cases we would get a more informative error from Kubernetes, not just "short buffer"

What this PR does / why we need it

Special notes for your reviewer

You shouldn't delete the branch after the merge, because it is used to build deckhouse 1.65

WIP
Signed-off-by: Daniil Stepanenko <[email protected]>
@libmonsoon-dev libmonsoon-dev self-assigned this Nov 7, 2024
@libmonsoon-dev libmonsoon-dev added the release-note/ignore Skip in the release message label Nov 7, 2024
@yalosev yalosev merged commit 9435e33 into main Nov 7, 2024
10 of 11 checks passed
@yalosev yalosev deleted the crd-buf-size branch November 7, 2024 09:27
@libmonsoon-dev libmonsoon-dev restored the crd-buf-size branch November 7, 2024 09:47
libmonsoon-dev added a commit that referenced this pull request Nov 7, 2024
Signed-off-by: Daniil Stepanenko <[email protected]>
Co-authored-by: Daniil Stepanenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore Skip in the release message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants