chrooted bash executor #560
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miklezzzz
force-pushed
the
chrooted-bash-executor
branch
from
06e2250 to
104aff1
Compare
Signed-off-by: Mikhail Scherba <[email protected]>
miklezzzz
force-pushed
the
chrooted-bash-executor
branch
from
104aff1 to
bcb8093
Compare
miklezzzz
commented
Feb 10, 2025
| @@ -176,6 +180,7 @@ func (sh *ShellHook) getConfig() ([]byte, error) { | |||
| envs := make([]string, 0) | |||
| envs = append(envs, os.Environ()...) | |||
| args := []string{"--config"} | |||
| var stderrBuf bytes.Buffer | |||
There was a problem hiding this comment.
delete, as it was added for the sake of debugging
miklezzzz
commented
Feb 10, 2025
| } | ||
|
|
||
| // SetRequiredObjects sets the list of objects to implement in the chroot directory | ||
| func (mm *ModuleManager) SetRequiredObjects(objects ...environmentmanager.ObjectDescriptor) { |
There was a problem hiding this comment.
rename to clarify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What this PR does / why we need it
Special notes for your reviewer