Improve output when delete_snapshot is blocked by task #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safe_to_snap can fail because of snapshot tasks (and not just a snapshot being "IN PROGRESS" as the error message implies). This updates the wording of the error message to account for both scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if another snapshot task is blocking delete_snapshot, the task action is logged as DEBUG only and following is logged at the INFO level:
Unable to delete snapshot(s) because a snapshot is in state "IN_PROGRESS"If there is actually another snapshot in progress, this message is accurate, but this message is also thrown if there are any other tasks with actions containing the word "snapshot" in the tasks list.
This PR makes the following changes:
utils/find_snapshot_tasks: Return the whole task object instead ofTrueif there is an active snapshot taskutils/safe_to_snap: Print the contents of the active snapshot task object if there is one.actions/DeleteSnapshots/do_action: Change the wording of the error message to allow for failure due to "other snapshot activity" (and not just in progress snapshots).