refactor: flarum 2.0 upgrade #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies to Flarum 2.0 compatible versions.
Update the extension infrastructure
Some Flarum modules are now lazy loaded. Extending them requires a different approach.
Miscellaneous frontend changes
Miscellaneous backend changes
Start by formatting your code with Prettier.
Flarum 2.0 completely changes the JSON:API implementation
Flarum 2.0 uses PHPUnit 11 and encourages use of model factories for easier cross-database testing.
Many variables have been renamed to light/dark specific names and most are now used as CSS variables instead.
…views You now need to provide both plain text and HTML views for notification emails.
@SychO9 must have been a global str replace that did this, ammended
|
Should this PR also handle the renaming of the extension? I remember it was discussed for 2.0, but I don't know if one was chosen, ie |
|
@iamdarkle we just renamed it to flarum/gdpr from blomstra/gdpr so i don't think we'll want to rename it again. |
|
@iamdarkle feel free to push this onto the ideation discussion for 2.0+, we can either complete functionality to make it further GDPR compliant or focus entirely on data management alone 🤔 |
luceos
requested changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.