Update godoc, remove unused getter for access list, add CLI flag to b…

…uilder flag list, update log level for multi-tx-snap error

cmd/geth/main.go

@@ -159,6 +159,7 @@ var (
 
 	builderApiFlags = []cli.Flag{
 		utils.BuilderEnabled,
+		utils.BuilderEnableMultiTxSnapshot,
 		utils.BuilderEnableValidatorChecks,
 		utils.BuilderBlockValidationBlacklistSourceFilePath,
 		utils.BuilderEnableLocalRelay,

core/state/statedb.go

@@ -1201,10 +1201,6 @@ func (s *StateDB) convertAccountSet(set map[common.Address]struct{}) map[common.
 	return ret
 }
 
-func (s *StateDB) AccessList() *accessList {
-	return s.accessList
-}
-
 // MultiTxSnapshot creates new checkpoint for multi txs reverts
 func (s *StateDB) MultiTxSnapshot() error {
 	if s.multiTxSnapshot != nil {

miner/algo_common.go

@@ -80,8 +80,8 @@ type (
 		// is 10 (i.e. 10%), then the minimum effective gas price included in the same bucket as the top transaction
 		// is (1000 * 10%) = 100 wei.
 		PriceCutoffPercent int
-		// EnableMultiTxSnap is true if we want to use multi-transaction snapshot
-		// for committing transactions (note: experimental)
+		// EnableMultiTxSnap is true if we want to use multi-transaction snapshot for committing transactions,
+		// which reduce state copies when reverting failed bundles (note: experimental)
 		EnableMultiTxSnap bool
 	}
 

miner/algo_greedy_buckets.go

@@ -62,7 +62,7 @@ func newGreedyBucketsBuilder(
 				orders,
 			)
 			if err != nil {
-				log.Debug("Error(s) building multi-tx snapshot block", "err", err)
+				log.Trace("Error(s) building multi-tx snapshot block", "err", err)
 			}
 			return builder.inputEnvironment, usedBundles, usedSbundles
 		}

miner/worker.go

@@ -1509,7 +1509,8 @@ func (w *worker) generateWork(params *generateParams) (*types.Block, *big.Int, e
 			totalSbundles++
 		}
 
-		log.Info("Block finalized and assembled", "height", block.Number().String(), "blockProfit", ethIntToFloat(profit),
+		log.Info("Block finalized and assembled",
+			"height", block.Number().String(), "blockProfit", ethIntToFloat(profit),
 			"txs", len(env.txs), "bundles", len(blockBundles), "okSbundles", okSbundles, "totalSbundles", totalSbundles,
 			"gasUsed", block.GasUsed(), "time", time.Since(start))
 		if metrics.EnabledBuilder {