fix memory leak in prefetcher

flashbots · Feb 12, 2024 · 992725a · 992725a
1 parent 5e90070
commit 992725a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/miner/algo_greedy.go b/miner/algo_greedy.go
@@ -113,6 +113,7 @@ func (b *greedyBuilder) mergeOrdersIntoEnvDiff(
 func (b *greedyBuilder) buildBlock(simBundles []types.SimulatedBundle, simSBundles []*types.SimSBundle, transactions map[common.Address][]*txpool.LazyTransaction) (*environment, []types.SimulatedBundle, []types.UsedSBundle) {
 	orders := newTransactionsByPriceAndNonce(b.inputEnvironment.signer, transactions, simBundles, simSBundles, b.inputEnvironment.header.BaseFee)
 	envDiff := newEnvironmentDiff(b.inputEnvironment.copy())
+	b.inputEnvironment.state.StopPrefetcher()
 	usedBundles, usedSbundles := b.mergeOrdersIntoEnvDiff(envDiff, orders)
 	envDiff.applyToBaseEnv()
 	return envDiff.baseEnvironment, usedBundles, usedSbundles

diff --git a/miner/algo_greedy_buckets.go b/miner/algo_greedy_buckets.go
@@ -226,6 +226,7 @@ func (b *greedyBucketsBuilder) mergeOrdersIntoEnvDiff(
 func (b *greedyBucketsBuilder) buildBlock(simBundles []types.SimulatedBundle, simSBundles []*types.SimSBundle, transactions map[common.Address][]*txpool.LazyTransaction) (*environment, []types.SimulatedBundle, []types.UsedSBundle) {
 	orders := newTransactionsByPriceAndNonce(b.inputEnvironment.signer, transactions, simBundles, simSBundles, b.inputEnvironment.header.BaseFee)
 	envDiff := newEnvironmentDiff(b.inputEnvironment.copy())
+	b.inputEnvironment.state.StopPrefetcher()
 	usedBundles, usedSbundles := b.mergeOrdersIntoEnvDiff(envDiff, orders)
 	envDiff.applyToBaseEnv()
 	return envDiff.baseEnvironment, usedBundles, usedSbundles