remove panic from worker.go

flashbots · Mar 11, 2024 · aa132a4 · aa132a4
1 parent e355bb9
commit aa132a4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/miner/environment_diff.go b/miner/environment_diff.go
@@ -74,7 +74,7 @@ func (envDiff *environmentDiff) applyToBaseEnv() {
 func (envDiff *environmentDiff) commitBlobTx(tx *types.Transaction, chData chainData) (*types.Receipt, int, error) {
 	sc := tx.BlobTxSidecar()
 	if sc == nil {
-		panic("blob transaction without blobs in miner")
+		return nil, popTx, errors.New("blob transaction without blobs in miner")
 	}
 	// Checking against blob gas limit: It's kind of ugly to perform this check here, but there
 	// isn't really a better place right now. The blob gas limit is checked at block validation time

diff --git a/miner/worker.go b/miner/worker.go
@@ -862,7 +862,7 @@ func (w *worker) commitTransaction(env *environment, tx *types.Transaction) ([]*
 func (w *worker) commitBlobTransaction(env *environment, tx *types.Transaction) ([]*types.Log, error) {
 	sc := tx.BlobTxSidecar()
 	if sc == nil {
-		panic("blob transaction without blobs in miner")
+		return nil, errors.New("blob transaction without blobs in miner")
 	}
 	// Checking against blob gas limit: It's kind of ugly to perform this check here, but there
 	// isn't really a better place right now. The blob gas limit is checked at block validation time