This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Validation jun 10 #162
Merged
Validation jun 10 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid any possibly underflowing substractions
metachris
approved these changes
Jun 26, 2024
avalonche
reviewed
Jun 26, 2024
| @@ -845,6 +845,99 @@ func executableDataToBlockValidationRequest(execData *engine.ExecutableData, pro | |||
| return blockRequest, nil | |||
| } | |||
|
|
|||
| func TestValidateBuilderSubmissionV2_CoinbasePaymentUnderflow(t *testing.T) { | |||
There was a problem hiding this comment.
should use the v3 builder submission which is currently being used, though ideally the unit test should just be calling ValidatePayload
avalonche
approved these changes
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes an unsigned integer underflow bug in coinbase balance diff calculation.
📚 References
https://collective.flashbots.net/t/disclosure-underflow-bug-in-mev-boost-relay/3599
CONTRIBUTING.md