Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Pass discard flag to miner from builder, revertible transaction gas used #95

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Pass discard flag to miner from builder, revertible transaction gas used #95

merged 1 commit into from
Aug 9, 2023

Conversation

Wazzymandias
Copy link
Contributor

📝 Summary

  • Miner uses revertible discard transaction flag, updated to pass that in
  • When revertible transactions are enabled, there can be bundles with zero transactions in them - this causes there to be a zero value for gas used

📚 References

@Wazzymandias
Pass discard flag to miner from builder, fix division by zero when re…
db0afb6 
…vert transaction is removed from bundle creating empty bundle with 0 gas used
@Wazzymandias Wazzymandias merged commit 9a7a6ed into main Aug 9, 2023
3 checks passed
@Wazzymandias Wazzymandias deleted the bugfix-pass-revert-flag-to-miner branch August 9, 2023 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvush dvush dvush approved these changes

@avalonche avalonche avalonche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wazzymandias @dvush @avalonche