Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deprecated forks and add deneb support #486

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

avalonche
Copy link
Collaborator

πŸ“ Summary

Removing deprecated networks such as zhejiang and ropsten. Add the deneb fork versions (fork versions are placeholders for now).

β›± Motivation and Context

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #486 (af47497) into main (372dcd1) will decrease coverage by 0.18%.
Report is 3 commits behind head on main.
The diff coverage is 7.84%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   30.58%   30.41%   -0.18%     
==========================================
  Files          24       24              
  Lines        4783     4810      +27     
==========================================
  Hits         1463     1463              
- Misses       3121     3148      +27     
  Partials      199      199              
Flag Coverage Ξ”
unittests 30.41% <7.84%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Ξ”
common/types.go 2.09% <0.00%> (-0.09%) ⬇️
services/api/service.go 34.08% <14.28%> (-0.14%) ⬇️
services/api/utils.go 12.30% <33.33%> (+3.83%) ⬆️

jtraglia
jtraglia previously approved these changes Jul 28, 2023
Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to me. Just one suggestion (which you could ignore).

common/types.go Outdated Show resolved Hide resolved
Co-authored-by: Justin Traglia <[email protected]>
Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@jtraglia jtraglia merged commit bd34715 into main Aug 1, 2023
4 checks passed
@jtraglia jtraglia deleted the add-deneb-fork branch August 1, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants