Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code health] rename cont to ok #497

Merged
merged 6 commits into from
Aug 3, 2023
Merged

[code health] rename cont to ok #497

merged 6 commits into from
Aug 3, 2023

Conversation

michaelneuder
Copy link
Collaborator

📝 Summary

Replace cont local with ok to be more idomatic.


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

Codecov Report

Merging #497 (566a202) into main (bcc805c) will not change coverage.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   31.40%   31.40%           
=======================================
  Files          24       24           
  Lines        4853     4853           
=======================================
  Hits         1524     1524           
  Misses       3136     3136           
  Partials      193      193           
Flag Coverage Δ
unittests 31.40% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
services/api/service.go 37.08% <50.00%> (ø)

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@michaelneuder michaelneuder merged commit 9c6216b into main Aug 3, 2023
4 checks passed
@michaelneuder michaelneuder deleted the cleanups-3 branch August 3, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants